← GF Guide Index Reviewing PRs and Sandbox
🐯 This chapter aims to share the validation process of a font from the moment it is in a google/fonts PR. To fix issues you will need to know about the other related repository: the Axis Registry, Glyphsets and Lang. You need to know this entire documentation. You need to communicate with the internal engineer team.
Table of contents
Before merging a PR
There are at least 2 labels: ready for review + new/upgrade/small fix.
If upgrade; an orange label.
If complex script: green label.
PR is in traffic jam
Issue is linked
No easy-to-fix warns
Has all necessary subsets
If noto: has languages
If complex script: has primary script
If optical size axis: check default or override
Correct designer name
URL is consistent with description and License
Consistent github URL with METADATA.pb and Description
If Noto: article is linked
Respect the rules (3rd person etc.)
URL is consistent with Licence and METADATA.pb
Checks (download artifacts)
Diffbrowser If pass
Add “to sandbox label”, remove “ready for review” and merge.
Add font to the to_sandbox list.
Report the issue in comment of the PR
Add appropriate label (“need confirmation”, “regression”, “needs upstream resolutuon” etc.)
Review again after corrective commit happen
Checking in Sandbox
Making sure the font was pushed
To check if the font behave correctly
Double checking previous QA before sending to prod. Most problems could be avoided with thorough QA before merging, but errors can happen.
The proper Primary script is displayed
Primary script is displayed first
All expected instances (every 100) are displayed and look okay
Any kind of weirdness
Font style matches category
All axes work
No interpolation issue on the few glyphs displayed
Primary script first
Latin style matches the primary script style
No missing elements (image, URL, etc)
Package is downloadable
Font version is the expected one
Remove “to sandbox”, add “to production”
Add font to
Add “blocked” and “in sandbox”, remove “to sandbox”
report in comment of PR
Checking in prod
Quicly recheck just like in sandbox
Check it is the proper version
Add “live” to PR and remove “to prod”